Minor ReadMe updates and config files for Secret Manager #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pmaytak
commented
Jul 14, 2020
pmaytak
commented
- Added JSON files related to Secret Manager.
- Minor updates to ReadMe (samples 1-2, 1-3, 2-3) related to Identity Web 0.2.0.
- Cleaned up Startup.cs in sample 5-2.
pmaytak
changed the title
jmprieur
approved these changes
Jul 14, 2020
| // See https://docs.microsoft.com/en-us/aspnet/core/security/authorization/roles for more info. | ||
| // Use the groups claim for populating roles | ||
| options.TokenValidationParameters.RoleClaimType = "groups"; |
There was a problem hiding this comment.
I think that given there is a groups claims we'd better offer in Microsoft identity we method to verify that things are in groups, rather than doing a hack of mapping the claim so that it can be used in the Authorize attribute?
What do you think, @pmaytak ? @jennyf19 ? @kalyankrishna1 @TiagoBrenck @Shama-K ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.